Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Browser title independent from rebuild. #668

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

fabianbrandscheid
Copy link

Follow up PR from this: #652 because issue still exists.

@fabianbrandscheid
Copy link
Author

@slovnicki Can you take a look at the PR, when you find some time? :)

@stan-at-work
Copy link
Contributor

LGTM ✅

@slovnicki
Copy link
Owner

Hey @fabianbrandscheid 👋
Thank for the PR!

I see some issues, will look into it later today or tomorrow.

@fabianbrandscheid
Copy link
Author

@slovnicki Thank you!

When you need some help, feel free to contact me :)

@slovnicki
Copy link
Owner

@fabianbrandscheid I now fully understand the need for this functionality.
I've been able to create a use case where we need to update browser title and there is no other way except having html.document.title = title; in one's project.

The use case is when we are doing Beamer.of(context).update(... rebuild: false). Route information (URL) is updated correctly, but browser title not because it gets called only during build (which is a mistake).

This tells me we should call setTabTitle in updateand not inbuild` so I would rewrite this PR differently. Let me know if you're ok with me closing this and we can open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants